Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

Daniel Stöckel the_docter at gmx.net
Fri Sep 7 12:16:44 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/
-----------------------------------------------------------

(Updated Sept. 7, 2012, 12:16 p.m.)


Review request for Amarok.


Changes
-------

Merged https://git.reviewboard.kde.org/r/106370/ as requested.


Description (updated)
-------

This simply sends a fake revision-number to the server.

Also appends the session-id field to the track URLs.

See: https://bugs.kde.org/show_bug.cgi?id=306351
See: https://bugs.kde.org/show_bug.cgi?id=306351


Diffs (updated)
-----

  src/core-impl/collections/daap/DaapMeta.h 5278b57 
  src/core-impl/collections/daap/DaapMeta.cpp a2429d7 
  src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 

Diff: http://git.reviewboard.kde.org/r/106366/diff/


Testing (updated)
-------

- Rhythmbox collections now correctly appear and play in Amarok.
- Validated that mt-daap collections are still working.


Thanks,

Daniel Stöckel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120907/3fef97d3/attachment.html>


More information about the Amarok-devel mailing list