Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

[Daniel Stöckel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/
-----------------------------------------------------------

(Updated Sept. 7, 2012, 1:07 p.m.)


Review request for Amarok.


Changes
-------

Moved the loginString assignment below the connect.


Description
-------

This simply sends a fake revision-number to the server.

Also appends the session-id field to the track URLs.

See: https://bugs.kde.org/show_bug.cgi?id=306351
See: https://bugs.kde.org/show_bug.cgi?id=306351


Diffs (updated)
-----

  src/core-impl/collections/daap/DaapMeta.h 5278b57 
  src/core-impl/collections/daap/DaapMeta.cpp a2429d7 
  src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 

Diff: http://git.reviewboard.kde.org/r/106366/diff/


Testing
-------

- Rhythmbox collections now correctly appear and play in Amarok.
- Validated that mt-daap collections are still working.


Thanks,

Daniel Stöckel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120907/5e2fabca/attachment.html>