Review Request: Fix DAAP collections published by Rhythmbox not showing up in Amarok.

[Daniel Stöckel]

> On Sept. 7, 2012, 11:38 a.m., Bart Cerneels wrote:
> > Cool, about time the DAAP Collection gets some love. Hope we can expect more patches from you.
> > 
> > Is there a published spec we can develop against?
> > 
> > I'll test later that this still works with the mt-daap I'm running (Firefly Media Server: Version svn-1676 on a netgear readynas Duo v1)

Hi, i did not find a definite, usable spec. The closest i got can be found here: http://www.scribd.com/doc/55630645/Daap-Specs
This should be the spec that once could be found under http://tapjam.net/daap/ which is now dead.
Every other spec has vanished || unmaintained || horribly incomplete.

What i did was to simply fire up wireshark and see what banshee did ;-)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106366/#review18649
-----------------------------------------------------------


On Sept. 7, 2012, 12:16 p.m., Daniel Stöckel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106366/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 12:16 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This simply sends a fake revision-number to the server.
> 
> Also appends the session-id field to the track URLs.
> 
> See: https://bugs.kde.org/show_bug.cgi?id=306351
> See: https://bugs.kde.org/show_bug.cgi?id=306351
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/DaapMeta.h 5278b57 
>   src/core-impl/collections/daap/DaapMeta.cpp a2429d7 
>   src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 
> 
> Diff: http://git.reviewboard.kde.org/r/106366/diff/
> 
> 
> Testing
> -------
> 
> - Rhythmbox collections now correctly appear and play in Amarok.
> - Validated that mt-daap collections are still working.
> 
> 
> Thanks,
> 
> Daniel Stöckel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120907/da626be4/attachment.html>