Review Request: Fix: Recently played tracks are not updated in currrent track applet.

Conrad Hübler conrad-huebler at arcor.de
Thu Mar 29 18:07:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101015/
-----------------------------------------------------------

(Updated March 29, 2012, 6:07 p.m.)


Review request for Amarok.


Changes
-------

A new approach to this problem. 

No tracks will be added to list after the last track has stopped, instead a timer will (re)start and update the list after 60 seconds. Btw, I added an option to decide how many tracks are to be displayed in the list.

Imo this is the easiest way to solve the problem. The solution won't last long since there are plans for qmlify the context view.


Description
-------

The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.

It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.


Diffs (updated)
-----

  src/context/applets/currenttrack/CurrentTrack.h e023e91 
  src/context/applets/currenttrack/CurrentTrack.cpp 916c829 
  src/context/applets/currenttrack/currentTrackSettings.ui c006384 
  src/context/widgets/RecentlyPlayedListWidget.h 37032cb 
  src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 

Diff: http://git.reviewboard.kde.org/r/101015/diff/


Testing
-------


Thanks,

Conrad Hübler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120329/48f21fe3/attachment.html>


More information about the Amarok-devel mailing list