Review Request: StatSyncing GSoC week 1 (squashed commits, recent on top)

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105055/
-----------------------------------------------------------

(Updated June 11, 2012, 10:46 a.m.)


Review request for Amarok, Bart Cerneels and Myriam Schweingruber.


Changes
-------

Add amarok group.


Description
-------

StatSyncing: move to amaroklib, back-end for collections, track matching

This commit implements following changes/features:
 * bury amarok-statsyncing.so: because CollectionManager in in amaroklib,
   there would be circular dependency which is not possible. StatSyncing
   is not part of amaroklib and built from src/CMakeLists.txt
 * a bridge between Amarok Collections, Meta and StatSyncing is
   implemented in statsyncing/collection. This means that StatSyncing can
   "see" collections and collection tracks, yay!
 * TrackDelegate comparisons are overhauled to be more intuitive to use
   and flexible because they accept comparison mask now
 * MatchTracksJob is implemented and called by Synchronize Statistics...
   action, it will match tracks from all visible collections

How to test: plug in all devices that show up as collection in Amarok,
start Amarok in console as amarok --debug. Hit "Synchronize Statistics...
from the Tools menu and watch all the beauty that appears in debugging
log. Notice the UI is still responsive while matching because it happens
in a background thread. I'm interested in first and last screen of that
debugging output, you may pastebin it and ping strohel at #amarok (IRC)
about it. Thanks. :-)

StatSyncing: introduce core (abstract) classes and Controller

This is the start of my GSoC project. Speaking about code layout,
StatSyncing is put into separate library: amarok-statsyncing that
links amarokcore and is linked by amaroklib. Statistics synchronization
is nicely isolated that way; I was more than inspired by transcoding
code when I designed this.

>From other code statistics synchronization is accessible through
Amarok::Components::statSyncingController().

This change also adds new action to the Tools menu:
"Synchronize Statistics..." that currently does nothing but emits
a line into debugging log. :-)


Diffs
-----

  src/App.cpp 30c6c6608418d54a150705c7f811f26c2d00afc7 
  src/CMakeLists.txt e2796a2265a2367b9398ab98c943760d483400f6 
  src/MainWindow.cpp 76f5cebc1cdb4fa2b93784c4500b55333b7ea66d 
  src/core/support/Components.h 93eaf45499293dabf5b8a1cb0be29a1df4c2a0cb 
  src/core/support/Components.cpp 22e5de0d0d2ce9303fdca31839f186bae5fe866d 
  src/statsyncing/Controller.h PRE-CREATION 
  src/statsyncing/Controller.cpp PRE-CREATION 
  src/statsyncing/TrackDelegate.h PRE-CREATION 
  src/statsyncing/TrackDelegate.cpp PRE-CREATION 
  src/statsyncing/TrackDelegateProvider.h PRE-CREATION 
  src/statsyncing/TrackDelegateProvider.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegate.h PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegate.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegateProvider.h PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegateProvider.cpp PRE-CREATION 
  src/statsyncing/jobs/MatchTracksJob.h PRE-CREATION 
  src/statsyncing/jobs/MatchTracksJob.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105055/diff/


Testing
-------


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120611/f88e86f3/attachment.html>