<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105055/">http://git.reviewboard.kde.org/r/105055/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Bart Cerneels and Myriam Schweingruber.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated June 11, 2012, 10:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add amarok group.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">StatSyncing: move to amaroklib, back-end for collections, track matching
This commit implements following changes/features:
* bury amarok-statsyncing.so: because CollectionManager in in amaroklib,
there would be circular dependency which is not possible. StatSyncing
is not part of amaroklib and built from src/CMakeLists.txt
* a bridge between Amarok Collections, Meta and StatSyncing is
implemented in statsyncing/collection. This means that StatSyncing can
"see" collections and collection tracks, yay!
* TrackDelegate comparisons are overhauled to be more intuitive to use
and flexible because they accept comparison mask now
* MatchTracksJob is implemented and called by Synchronize Statistics...
action, it will match tracks from all visible collections
How to test: plug in all devices that show up as collection in Amarok,
start Amarok in console as amarok --debug. Hit "Synchronize Statistics...
from the Tools menu and watch all the beauty that appears in debugging
log. Notice the UI is still responsive while matching because it happens
in a background thread. I'm interested in first and last screen of that
debugging output, you may pastebin it and ping strohel at #amarok (IRC)
about it. Thanks. :-)
StatSyncing: introduce core (abstract) classes and Controller
This is the start of my GSoC project. Speaking about code layout,
StatSyncing is put into separate library: amarok-statsyncing that
links amarokcore and is linked by amaroklib. Statistics synchronization
is nicely isolated that way; I was more than inspired by transcoding
code when I designed this.
>From other code statistics synchronization is accessible through
Amarok::Components::statSyncingController().
This change also adds new action to the Tools menu:
"Synchronize Statistics..." that currently does nothing but emits
a line into debugging log. :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/App.cpp <span style="color: grey">(30c6c6608418d54a150705c7f811f26c2d00afc7)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(e2796a2265a2367b9398ab98c943760d483400f6)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(76f5cebc1cdb4fa2b93784c4500b55333b7ea66d)</span></li>
<li>src/core/support/Components.h <span style="color: grey">(93eaf45499293dabf5b8a1cb0be29a1df4c2a0cb)</span></li>
<li>src/core/support/Components.cpp <span style="color: grey">(22e5de0d0d2ce9303fdca31839f186bae5fe866d)</span></li>
<li>src/statsyncing/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackDelegateProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/TrackDelegateProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionTrackDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionTrackDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionTrackDelegateProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/collection/CollectionTrackDelegateProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/statsyncing/jobs/MatchTracksJob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105055/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>