Review Request: StatSyncing GSoC week 2 (squashed commits, recent on top)

Matěj Laitl matej at laitl.cz
Mon Jun 11 10:47:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105100/
-----------------------------------------------------------

(Updated June 11, 2012, 10:47 a.m.)


Review request for Amarok, Bart Cerneels and Myriam Schweingruber.


Changes
-------

Add amarok group.


Description
-------

StatSyncing: renames, models, gui for matched tracks

 * TrackDelegate is renamed to Track (encapsulated in namespace),
   TrackDelegateProvider is Provider; subclasses are renamed accordingly
 * Process class introduced and implemented to handle one stats
   synchronization; makes Controller more lean
 * TrackTuple class introduced to facilitate stats syncing of a pack of
   equal tracks from different providers; currently just a container
   for track packs associated to their providers
 * MatchedTracksModel (QAbstractItemModel) implemented to serve as
   a source for UI displaying matched tracks
 * SingleTracksModel (QAbstractListModel) implemented for displaying
   non-matched tracks
 * Rudimentary UI for displaying results of track matching (will be
   extended with more statsyncing controls)
 * smaller fixes all over: fixes inclusion guards, provider
   memory-management, docs...
 * putting it all together. :-)

StatSyncing: progress bar for matching track, abort-ability


Diffs
-----

  src/CMakeLists.txt a54e2dcbea4ad415d2f5a25c6cd925bf7760b625 
  src/statsyncing/Controller.h PRE-CREATION 
  src/statsyncing/Controller.cpp PRE-CREATION 
  src/statsyncing/Process.h PRE-CREATION 
  src/statsyncing/Process.cpp PRE-CREATION 
  src/statsyncing/Provider.h PRE-CREATION 
  src/statsyncing/Provider.cpp PRE-CREATION 
  src/statsyncing/Track.h PRE-CREATION 
  src/statsyncing/Track.cpp PRE-CREATION 
  src/statsyncing/TrackDelegate.h PRE-CREATION 
  src/statsyncing/TrackDelegate.cpp PRE-CREATION 
  src/statsyncing/TrackDelegateProvider.h PRE-CREATION 
  src/statsyncing/TrackDelegateProvider.cpp PRE-CREATION 
  src/statsyncing/TrackTuple.h PRE-CREATION 
  src/statsyncing/TrackTuple.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionProvider.h PRE-CREATION 
  src/statsyncing/collection/CollectionProvider.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionTrack.h PRE-CREATION 
  src/statsyncing/collection/CollectionTrack.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegate.h PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegate.cpp PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegateProvider.h PRE-CREATION 
  src/statsyncing/collection/CollectionTrackDelegateProvider.cpp PRE-CREATION 
  src/statsyncing/jobs/MatchTracksJob.h PRE-CREATION 
  src/statsyncing/jobs/MatchTracksJob.cpp PRE-CREATION 
  src/statsyncing/models/CommonModel.h PRE-CREATION 
  src/statsyncing/models/CommonModel.cpp PRE-CREATION 
  src/statsyncing/models/MatchedTracksModel.h PRE-CREATION 
  src/statsyncing/models/MatchedTracksModel.cpp PRE-CREATION 
  src/statsyncing/models/SingleTracksModel.h PRE-CREATION 
  src/statsyncing/models/SingleTracksModel.cpp PRE-CREATION 
  src/statsyncing/ui/MatchedTracksPage.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105100/diff/


Testing
-------


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120611/36613676/attachment-0001.html>


More information about the Amarok-devel mailing list