GSoC Report: Integrate Spotify into Amarok

[Bart Cerneels]

On Sat, Jul 14, 2012 at 4:46 PM, Ryan Feng <odayfans at gmail.com> wrote:
> Hi,
>
>    The last report already showed that the Spotify plugin has been loaded
> correctly and the collection is working, but sometimes the search results
> are inserted into the collection but fail showing up in the collection, now
> my next move is to fix that problem.
>
> Here's a list of already known issues and todos:
>
> Slot SpotifyQueryMaker::collectResults() is connected but will never be
> executed, I think it is because the SpotifyQueryMaker is deleted before the
> results are returned. I added addToCollection() in Query::tracksAdded() to
> work around this.  Currently the SpotifyCollection::querymaker() creates and
> returns a new SpotifyQueryMaker object when called, but it's not encouraged
> to do so.
> Track length is always zero
> Track tags are missing after Amarok reload
>
> Todos:
>
> Create a SpotifyQueryMaker object, reuse it and try to fix the problem.
> Fix SpotifyCollection::trackForUrl() to load track tags when starting
> Amarok.
> Create a configuration dialog to input Spotify username and password.
>
> Repos:
> http://goo.gl/ewd1n in the `gsoc-spotify` branch
>
> Diff:
> https://git.reviewboard.kde.org/r/105285/diff/2/
>

gsoc-spotify in that repo and the patch don't match. Could you do a
git push kde:clones/amarok/zhengliangfeng/amarok-spotify.git
gsoc-spotify:gsoc-spotify to make sure it's up to date. If that
command does not work, as on IRC.