Review Request: Amarok: do not stop transfers when some files are already at destination

[Matěj Laitl]

On Dec. 22, 2012, 10:18 a.m., Dmitry Torokhov wrote:
> > Another remark: this closes a bug/changes behaviour, ChangeLog entry is needed, if you have time, please update the patch, add a line on top of 2.7 BUGFIXES in ChangeLog. If you want to be perfect, you can add BUG, REVIEW, FIXED-IN commit message tags, see http://quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template .
> 
> Dmitry Torokhov wrote:
>     Mat?j,
>     
>     Thank you for reviewing and submitting it. Unfortunately our schedules are sufficiently apart so that I could not address your feedback before you committed it.
>     
>     Thanks,
>     Dmitry

No problem, it was rather no work, I often just nitpick so that next time the patch author will already know.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107841/#review23830
-----------------------------------------------------------


On Dec. 21, 2012, 9:21 p.m., Dmitry Torokhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107841/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 9:21 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Amarok: do not stop transfers when some files are already at destination
> 
> This happens when you want to import a big tree of tracks at once and some
> tracks are already present in the destination collection. In this case
> TransferJob's copy subjob fails with KIO::ERR_FILE_ALEADY_EXIST and causes
> entire transfer to complete prematurely.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> 
> 
> This addresses bug 312001.
>     https://bugs.kde.org/show_bug.cgi?id=312001
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/SqlCollectionLocation.h c536f5626ea4ab24dc5afc0c24a779c61a004876 
>   src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 0b794db8d93e20634bf5271f16f3b63b5dffe97d 
> 
> Diff: http://git.reviewboard.kde.org/r/107841/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Torokhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121222/5ed7edd6/attachment.html>