<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107841/">http://git.reviewboard.kde.org/r/107841/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 22nd, 2012, 10:18 a.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another remark: this closes a bug/changes behaviour, ChangeLog entry is needed, if you have time, please update the patch, add a line on top of 2.7 BUGFIXES in ChangeLog. If you want to be perfect, you can add BUG, REVIEW, FIXED-IN commit message tags, see http://quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template .</pre>
</blockquote>
<p>On December 22nd, 2012, 10:58 p.m., <b>Dmitry Torokhov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mat?j,
Thank you for reviewing and submitting it. Unfortunately our schedules are sufficiently apart so that I could not address your feedback before you committed it.
Thanks,
Dmitry</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No problem, it was rather no work, I often just nitpick so that next time the patch author will already know.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On December 21st, 2012, 9:21 p.m., Dmitry Torokhov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Dmitry Torokhov.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2012, 9:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Amarok: do not stop transfers when some files are already at destination
This happens when you want to import a big tree of tracks at once and some
tracks are already present in the destination collection. In this case
TransferJob's copy subjob fails with KIO::ERR_FILE_ALEADY_EXIST and causes
entire transfer to complete prematurely.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=312001">312001</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.h <span style="color: grey">(c536f5626ea4ab24dc5afc0c24a779c61a004876)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(0b794db8d93e20634bf5271f16f3b63b5dffe97d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107841/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>