Review Request: Amarok: do not stop transfers when some files are already at destination

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107841/#review23868
-----------------------------------------------------------


This review has been submitted with commit 32c9f7ebf8ca7abf6d5397d9d74cadaa8c676ec2 by Matěj Laitl on behalf of Dmitry Torokhov to branch master.

- Commit Hook


On Dec. 21, 2012, 9:21 p.m., Dmitry Torokhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107841/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 9:21 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Amarok: do not stop transfers when some files are already at destination
> 
> This happens when you want to import a big tree of tracks at once and some
> tracks are already present in the destination collection. In this case
> TransferJob's copy subjob fails with KIO::ERR_FILE_ALEADY_EXIST and causes
> entire transfer to complete prematurely.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> 
> 
> This addresses bug 312001.
>     https://bugs.kde.org/show_bug.cgi?id=312001
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/SqlCollectionLocation.h c536f5626ea4ab24dc5afc0c24a779c61a004876 
>   src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 0b794db8d93e20634bf5271f16f3b63b5dffe97d 
> 
> Diff: http://git.reviewboard.kde.org/r/107841/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Torokhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121222/ec3d9a14/attachment.html>