Review Request: Extend the scope of the playground

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103999/#review17516
-----------------------------------------------------------


The autor says he doesn't intend to see this merged, to I presume we can close this now.

Ryan, as Bart says, there's some unrelated cleanup in this patch, could you please submit that as a separate review? Tracks.

- Matěj Laitl


On Feb. 17, 2012, 2:53 a.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103999/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2012, 2:53 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is infrastructure for future patches of mine. It's intended to (after some revising) make it relatively easy to develop code that is (mostly) in the playground directory but is (by necessity) compiled into the player binary.
> 
> Note: I'm only looking for criticism and have no intention of seeing this shipped.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d47c28b 
>   playground/CMakeLists.txt e96aa3f 
>   playground/src/CMakeLists.txt ed740ec 
>   src/App.cpp 2f1837c 
>   src/CMakeLists.txt 4241e69 
> 
> Diff: http://git.reviewboard.kde.org/r/103999/diff/
> 
> 
> Testing
> -------
> 
> Checked that the code compiles.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120816/83a01c44/attachment-0001.html>