<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103999/">http://git.reviewboard.kde.org/r/103999/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The autor says he doesn't intend to see this merged, to I presume we can close this now.
Ryan, as Bart says, there's some unrelated cleanup in this patch, could you please submit that as a separate review? Tracks.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On February 17th, 2012, 2:53 a.m., Ryan McCoskrie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ryan McCoskrie.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2012, 2:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is infrastructure for future patches of mine. It's intended to (after some revising) make it relatively easy to develop code that is (mostly) in the playground directory but is (by necessity) compiled into the player binary.
Note: I'm only looking for criticism and have no intention of seeing this shipped.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked that the code compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d47c28b)</span></li>
<li>playground/CMakeLists.txt <span style="color: grey">(e96aa3f)</span></li>
<li>playground/src/CMakeLists.txt <span style="color: grey">(ed740ec)</span></li>
<li>src/App.cpp <span style="color: grey">(2f1837c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4241e69)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103999/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>