Review Request: Add playlist export action to Playlist Dock save action.

[Ralf Engels]

> On Aug. 8, 2012, 11:36 a.m., Bart Cerneels wrote:
> > I wouldn't do this. Toolbars become less usable the more actions are in it.
> > What is wrong with using the menu with a function that is not supposed to be used to often?
> 
> Matěj Laitl wrote:
>     Did you say this with knowing that this doesn't add another toolbar enty, just one more item to the menu of the Save toolbar button? Ralf, this is really worth a screenshot.
> 
> Bart Cerneels wrote:
>     You are right, I didn't even though I had a quick glance at the code. I would have suggested to do it like that but I think it might be confusing.
>     
>     In any case removing it from the menu could upset existing users.

Let's summarize what is wrong with the current UI design (from my standpoint):
1. the playlist dock is the only dock that has it's own menu entry
2. inconsistency between the toolbar and the menu. You need to know where to find the option
3. toolbar button with multiple options is evil. You need to do a long press and the only indication that a user can do this is a tiny arrow.
4. toolbar is hidden as the playlist tab has in principle two. Hidden in this respect means that it's easy to overlook since people normally read from the top and the playlist dock has already an option bar at the top. So why look at the bottom?

In principle this patch improves on point 2.


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105824/#review17100
-----------------------------------------------------------


On Aug. 2, 2012, 12:14 p.m., Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105824/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 12:14 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Add playlist export action to Playlist Dock save action.
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistDock.cpp ae1644f 
> 
> Diff: http://git.reviewboard.kde.org/r/105824/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf Engels
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120808/f02bc6a4/attachment.html>