<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105824/">http://git.reviewboard.kde.org/r/105824/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 8th, 2012, 11:36 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't do this. Toolbars become less usable the more actions are in it.
What is wrong with using the menu with a function that is not supposed to be used to often?</pre>
</blockquote>
<p>On August 8th, 2012, 2:43 p.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you say this with knowing that this doesn't add another toolbar enty, just one more item to the menu of the Save toolbar button? Ralf, this is really worth a screenshot.</pre>
</blockquote>
<p>On August 8th, 2012, 2:48 p.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are right, I didn't even though I had a quick glance at the code. I would have suggested to do it like that but I think it might be confusing.
In any case removing it from the menu could upset existing users.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's summarize what is wrong with the current UI design (from my standpoint):
1. the playlist dock is the only dock that has it's own menu entry
2. inconsistency between the toolbar and the menu. You need to know where to find the option
3. toolbar button with multiple options is evil. You need to do a long press and the only indication that a user can do this is a tiny arrow.
4. toolbar is hidden as the playlist tab has in principle two. Hidden in this respect means that it's easy to overlook since people normally read from the top and the playlist dock has already an option bar at the top. So why look at the bottom?
In principle this patch improves on point 2.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On August 2nd, 2012, 12:14 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2012, 12:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add playlist export action to Playlist Dock save action.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(ae1644f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105824/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>