Review Request: Done some improvements on Gpodder Service

[Bart Cerneels]

On Nov. 3, 2011, 8:34 a.m., Lucas Gomes wrote:
> > I'll take a look at the provider not appearing at runtime, probably a QtGroupingProxy thing.
> 
> Lucas Gomes wrote:
>     Another problem is that the provider keep showing on PodcastBrowser even if I disable the gpodder service.

If you mean disabled in the PlaylistBrowser using the visible sources menu, this should be fixed.
If not you might not be de-registering the provider properly.


- Bart


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103034/#review7891
-----------------------------------------------------------


On Nov. 4, 2011, 1:27 a.m., Lucas Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103034/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2011, 1:27 a.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> -------
> 
> Done some improvements on GPodder Service.
> 
> Fixes:
> * Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems that the libmygpo-qt version fixed it)
> * GPodderProvider can be loaded in runtime also.
> * Preserve persistence of GPodderService EpisodeActions during shutdown and restart of Amarok. 
> * Now, we send EpisodeActions in Amarok start or when a user stop/pause and doesn't resume listening in 60 seconds.
> 
> Know bugs:
> * Even though GpodderProvider can be loaded during runtime, the PodcastBrowser is not showing it :/.
> 
> 
> Diffs
> -----
> 
>   ChangeLog 0b87f8e 
>   src/services/gpodder/GpodderProvider.h 8ddc802 
>   src/services/gpodder/GpodderProvider.cpp 15996f8 
>   src/services/gpodder/GpodderService.h 02ff539 
>   src/services/gpodder/GpodderService.cpp 9e04d38 
>   src/services/gpodder/amarok_service_gpodder.desktop 10661b7 
> 
> Diff: http://git.reviewboard.kde.org/r/103034/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111104/42a6e197/attachment-0001.html>