<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103034/">http://git.reviewboard.kde.org/r/103034/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2011, 8:34 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll take a look at the provider not appearing at runtime, probably a QtGroupingProxy thing.</pre>
</blockquote>
<p>On November 4th, 2011, 1:32 a.m., <b>Lucas Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another problem is that the provider keep showing on PodcastBrowser even if I disable the gpodder service.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you mean disabled in the PlaylistBrowser using the visible sources menu, this should be fixed.
If not you might not be de-registering the provider properly.</pre>
<br />
<p>- Bart</p>
<br />
<p>On November 4th, 2011, 1:27 a.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2011, 1:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done some improvements on GPodder Service.
Fixes:
* Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems that the libmygpo-qt version fixed it)
* GPodderProvider can be loaded in runtime also.
* Preserve persistence of GPodderService EpisodeActions during shutdown and restart of Amarok.
* Now, we send EpisodeActions in Amarok start or when a user stop/pause and doesn't resume listening in 60 seconds.
Know bugs:
* Even though GpodderProvider can be loaded during runtime, the PodcastBrowser is not showing it :/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(0b87f8e)</span></li>
<li>src/services/gpodder/GpodderProvider.h <span style="color: grey">(8ddc802)</span></li>
<li>src/services/gpodder/GpodderProvider.cpp <span style="color: grey">(15996f8)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: grey">(02ff539)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(9e04d38)</span></li>
<li>src/services/gpodder/amarok_service_gpodder.desktop <span style="color: grey">(10661b7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103034/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>