Review Request: Re-Add old "Normal" moodbar style
Florian Eßer
f.esser at rwth-aachen.de
Thu Nov 3 10:28:30 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103036/
-----------------------------------------------------------
Review request for Amarok.
Description
-------
This patch re-adds the old pre-2.4.0 moodbar "Normal" style as a fourth option in the moodbar style selection dialog.
Sorry to reheat the old topic from https://bugs.kde.org/show_bug.cgi?id=264432, but upgrading to Kubuntu 11.10 (overwriting my self-compiled Amarok version) made me recognize that this bug is still not fixed.
The old "Normal" style was and is *not* the (IMHO ugly) happy style, so 82d102ba32e0a1b6a154dfe4653e786229c0dcb7 did not really fix the bug. Please have a look at the attached screenshot for a comparison of the different moodbar styles.
This addresses bug 264432.
https://bugs.kde.org/show_bug.cgi?id=264432
Diffs
-----
src/configdialog/dialogs/GeneralConfig.ui 14b2d63
src/moodbar/MoodbarManager.cpp 53bea15
Diff: http://git.reviewboard.kde.org/r/103036/diff/diff
Testing
-------
worksforme
Screenshots
-----------
Comparison of different moodbar styles.
http://git.reviewboard.kde.org/r/103036/s/322/
Thanks,
Florian Eßer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111103/11cf6539/attachment.html>
More information about the Amarok-devel
mailing list