Review Request: Find field names (filter keywords) even if they are translated

[Daniel Faust]

> On Nov. 2, 2011, 9:40 a.m., Matěj Laitl wrote:
> > src/core/meta/support/MetaConstants.cpp, line 84
> > <http://git.reviewboard.kde.org/r/103014/diff/1/?file=40013#file40013line84>
> >
> >     Looks like you've also changed firstplay -> first? Seems both currently work in collection filter (because of a slightly different implementation in TextualQueryFilter.cpp), but I would stick with the old identifier.

Actually this wasn't intended. I just copied the code from TextualQueryFilter.cpp
But firstplay and lastplay sound more intuitive. I'll change that.
It seems, only then both versions work if amarok is set to english since 'first' is hard coded in TextualQueryFilter.cpp and shortI18nForField returns 'firstplay'.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/#review7858
-----------------------------------------------------------


On Nov. 1, 2011, 3:09 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103014/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 3:09 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> The filters (eg. filesize, artist) can be translated but without this patch components like the EditFilterDialog won't recognize the keywords.
> 
> I haven't committed it yet because it also changes the keyword 'modifydate' to 'modified' since i think that that's a bug, too.
> 
> 
> Diffs
> -----
> 
>   src/core/meta/support/MetaConstants.cpp fabb146 
> 
> Diff: http://git.reviewboard.kde.org/r/103014/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111102/03fd967b/attachment.html>