Review Request: Find field names (filter keywords) even if they are translated
Matěj Laitl
matej at laitl.cz
Wed Nov 2 09:40:21 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/#review7858
-----------------------------------------------------------
src/core/meta/support/MetaConstants.cpp
<http://git.reviewboard.kde.org/r/103014/#comment6795>
Looks like you've also changed firstplay -> first? Seems both currently work in collection filter (because of a slightly different implementation in TextualQueryFilter.cpp), but I would stick with the old identifier.
src/core/meta/support/MetaConstants.cpp
<http://git.reviewboard.kde.org/r/103014/#comment6796>
lastplay ? last?
src/core/meta/support/MetaConstants.cpp
<http://git.reviewboard.kde.org/r/103014/#comment6799>
It seems that Meta::playlistNameForField() is only used in Dynamic::TagMatchBias::toXml(). Anyone knows why it cannot use Meta::nameForField()? If it can migrated, code duplication would --.
- Matěj Laitl
On Nov. 1, 2011, 3:09 p.m., Daniel Faust wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103014/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2011, 3:09 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> The filters (eg. filesize, artist) can be translated but without this patch components like the EditFilterDialog won't recognize the keywords.
>
> I haven't committed it yet because it also changes the keyword 'modifydate' to 'modified' since i think that that's a bug, too.
>
>
> Diffs
> -----
>
> src/core/meta/support/MetaConstants.cpp fabb146
>
> Diff: http://git.reviewboard.kde.org/r/103014/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Faust
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111102/a442c256/attachment-0001.html>
More information about the Amarok-devel
mailing list