Review Request: Find field names (filter keywords) even if they are translated

[Daniel Faust]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/
-----------------------------------------------------------

(Updated Nov. 6, 2011, 5:45 p.m.)


Review request for Amarok.


Changes
-------

-changed keywords 'first'/'played' back to 'firstplay'/'lastplay'
-made TextualQueryFilter use Meta::fieldForName


Description
-------

The filters (eg. filesize, artist) can be translated but without this patch components like the EditFilterDialog won't recognize the keywords.

I haven't committed it yet because it also changes the keyword 'modifydate' to 'modified' since i think that that's a bug, too.


Diffs (updated)
-----

  src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
  src/core/meta/support/MetaConstants.cpp fabb146 

Diff: http://git.reviewboard.kde.org/r/103014/diff/diff


Testing
-------


Thanks,

Daniel Faust

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111106/206bd512/attachment.html>