Review Request: Playing albums (adding delay)

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100837/#review3394
-----------------------------------------------------------



src/playlist/navigators/RandomAlbumNavigator.cpp
<http://git.reviewboard.kde.org/r/100837/#comment2830>

    I think the default delay with audio cds is 3 seconds.


I don't like the navigator to be involved in this. 
I was thinking about a different solution. The EngineController could check if the next track is in the same album as the last one and if not add the delay.

Also I think we might really want a setting for that. In the playback settings panel there is empty space that really begs for that.

In addition: The Audio CD has a flag for gapless playback and this get's sometimes encoded in mp3 tags. See here:
http://en.wikipedia.org/wiki/Gapless_playback

ITunes handles that and stores the information about gapless playback somewhere in the audio file.

So, I think the final solution would be to check the audio tags. Actually I think that Phonon could do that. Maybe even SHOULD do that.

Any further thoughts?

- Ralf


On March 10, 2011, 10 p.m., Nicholas Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100837/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 10 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> When playing albums, I want add a delay between albums. Each album should ideally be played seamlessly, but jumping with not even a second's delay to a random album creates a very jarring effect. This is a preliminary patch to add a few seconds' pause in random album mode.
> 
> Questions:
> 1) UI. If this makes the cut, I guess there should be a config for it. The play modes menu is getting a bit cluttered, so perhaps it could be slightly re-engineered. I'll think about it if there is a chance of the feature being shipped.
> 2) Do we want this option to be available in normal album traversal? Adding a few seconds between albums, possibly with config, seems very sensible to me.
> 
> Also, the RandomAlbums mode needs some love. It currently ignores the favouring code which the UI suggests it should follow, and is less clever than the favoured track mode at avoiding playing the same thing again based on history. Would it be OK to fix that?
> 
> So, if I write it, will you take it, or is this feature not wanted?
> 
> 
> Diffs
> -----
> 
>   src/EngineController.h 4117a89 
>   src/EngineController.cpp ad85533 
>   src/playlist/navigators/RandomAlbumNavigator.cpp 6f0fe37 
> 
> Diff: http://git.reviewboard.kde.org/r/100837/diff
> 
> 
> Testing
> -------
> 
> Tested on local files only. Using it already to improve random albums experience.
> 
> 
> Thanks,
> 
> Nicholas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110518/b5469792/attachment.htm