Review Request: Trivial cosmetic fix to context view 'albums' applet
Ralf Engels
ralf-engels at gmx.de
Wed May 18 21:19:52 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100805/#review3392
-----------------------------------------------------------
Ship it!
Looks sensible.
Will be submitted until somebody else vetos it.
- Ralf
On March 9, 2011, 2:06 p.m., Nicholas Wilson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100805/
> -----------------------------------------------------------
>
> (Updated March 9, 2011, 2:06 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> A suggested fix for bug 263531. Trivial; changes layout in context view 'albums' applet to prevent "0." appearing in front of tracks with no track number set.
>
>
> This addresses bug 263531.
> https://bugs.kde.org/show_bug.cgi?id=263531
>
>
> Diffs
> -----
>
> src/context/applets/albums/AlbumsView.cpp 26c4dca
>
> Diff: http://git.reviewboard.kde.org/r/100805/diff
>
>
> Testing
> -------
>
> Works with albums having both tracks with and without track numbers. No number is shown for tracks without a track number and the track title is left aligned in the field (or right in RTL layouts).
>
>
> Thanks,
>
> Nicholas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110518/757d5cad/attachment.htm
More information about the Amarok-devel
mailing list