Review Request: Fetch cover for DAAP Albums #240060

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100176/#review3396
-----------------------------------------------------------


Just wanted to apply the patch (finally, sorry) but it doesn't apply cleanly any more.

Also I noticed that there is not much magic in it, just implementing the virtual members, and I am wondering if that couldn't be done in the super class?

Can you update the patch?

- Ralf


On Nov. 28, 2010, 3:03 p.m., Dennis Francis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100176/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2010, 3:03 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This is just a copy and paste attempt to introduce cover fetch functionality for DAAP albums. I used PlaydarMeta.h/.cpp as the reference.
> 
> Please suggest better methods !
> 
> The cover arts does not persists between multiple runs of amarok; it seems to load the art from internet everytime. Should I be using ServiceAlbumCoverDownloader which has implemented caching ?
> 
> 
> This addresses bug 240060.
>     https://bugs.kde.org/show_bug.cgi?id=240060
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/DaapMeta.h 8187d1e 
>   src/core-impl/collections/daap/DaapMeta.cpp 61aa0db 
> 
> Diff: http://git.reviewboard.kde.org/r/100176/diff
> 
> 
> Testing
> -------
> 
> I am using a firefly DAAP server. 
> Cover art is getting fetched in non-blocking mode.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110518/3d72610b/attachment-0001.htm