Review Request: Fix 260352: Show hidden tracks warning when tracks are removed after filtering

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100928/#review3346
-----------------------------------------------------------



src/playlist/view/listview/PrettyListView.h
<http://git.reviewboard.kde.org/r/100928/#comment2801>

    Shouldn't this variable be initialized when creating the PrettyListView instance?
    


Also I grepped a little through the source code.
Starting the complete search again (especially since the whole of PrettyListView does never do a search by itself) seems to be strange.

Couldn't you instead just call ProgressiveSearchWidget::showHiddenTracksWarning if you detect that after a delete you don't have any tracks left visible but a search term and a non-empty playlist.

Or even better. Re-write the whole stuff so that a PrettyListView shows the "Add tracks to the playlist to hear music." if it's empty and "All entries filtered out" if it's not really empty.


- Ralf


On March 23, 2011, 7:05 a.m., Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100928/
> -----------------------------------------------------------
> 
> (Updated March 23, 2011, 7:05 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Fix 260352 where removing tracks from the playlist after applying a filter, does not show the "Warning: tracks have been hidden in the playlist" label.
> 
> This fixes it by re-applying the filter on the PrettyListView so that it emits the found/notFound signals. Since the filter itself hasn't changed, proxy updates don't happen, so it shouldn't be a performance hit.
> 
> Change is minor but submitted for review since it is an unfamiliar piece of code, and also for educational purposes
> 
> 
> This addresses bug 260352.
>     https://bugs.kde.org/show_bug.cgi?id=260352
> 
> 
> Diffs
> -----
> 
>   src/playlist/view/listview/PrettyListView.h f22a7c8 
>   src/playlist/view/listview/PrettyListView.cpp cd650f6 
> 
> Diff: http://git.reviewboard.kde.org/r/100928/diff
> 
> 
> Testing
> -------
> 
> Yes, it works fine. It is shown only when all filtered tracks are deleted as expected.
> 
> 
> Thanks,
> 
> Nikhil Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110516/60067055/attachment.htm