Review Request: Fix use of deprecated avcodec_decode_audio2 in MusicBrainz support

Sam Lade sam at sentynel.com
Mon May 16 21:41:35 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101372/
-----------------------------------------------------------

Review request for Amarok and Sergey Ivanov.


Summary
-------

The function avcodec_decode_audio2 and the constant CODEC_TYPE_AUDIO are deprecated, and have been removed in the latest git version of ffmpeg.
This patch switches these to avcodec_decode_audio3 and AVMEDIA_TYPE_AUDIO respectively, removing deprecation warnings and fixing building on latest git ffmpeg.


Diffs
-----

  src/musicbrainz/MusicDNSAudioDecoder.cpp 6d82bb0 

Diff: http://git.reviewboard.kde.org/r/101372/diff


Testing
-------

Amarok builds successfully with latest git ffmpeg.
MusicBrainz tagging works correctly.


Thanks,

Sam

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110516/cdcc0707/attachment.htm 


More information about the Amarok-devel mailing list