Review Request: Fix "smb" and "nfs" remote collections to work with Dynamic Collections

[Peter C. Ndikuwera]

I shipped this ages ago - forgot to update it.

It fixed these bugs: 249760, 232976, 171213, 187692

Peter

--
Evolution (n): A hypothetical process whereby infinitely improbable events
occur with alarming frequency, order arises from chaos, and no one is given
credit.



On 16 May 2011 20:43, Ralf Engels <ralf-engels at gmx.de> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100725/
>
> Ship it!
>
> The patch looks good in principle.
>
> I am wondering, is there a bug entry that this patch fixes?
>
>
> - Ralf
>
> On February 23rd, 2011, 7:34 p.m., Peter C. Ndikuwera wrote:
>   Review request for Amarok.
> By Peter C. Ndikuwera.
>
> *Updated Feb. 23, 2011, 7:34 p.m.*
> Description
>
> Used MassStorageDeviceHandler as a template, then changed the following:
>
> SQLStorage - should use StorageAccess instead of StorageVolume. StorageVolume only sees physical volumes on the local PC. StorageAccess sees all accessible storage.
>
> NFS & SMS DeviceHandlers use KMountPoint to find where the disk is mounted.
>
>   Testing
>
> Mounted nfs and samba/cifs shares and did full rescans. Then unmounted them one by one. Works perfectly.
>
> Haven't tested what happens if you mount a share that's _not_ in /etc/fstab.
>
>   Diffs
>
>    - src/core-impl/collections/db/sql/MountPointManager.cpp (ed29f48)
>    - src/core-impl/collections/db/sql/device/CMakeLists.txt (1baaf85)
>    - src/core-impl/collections/db/sql/device/nfs/CMakeLists.txt (6807dd6)
>    - src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.h
>    (21c1894)
>    - src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.cpp
>    (91af710)
>    - src/core-impl/collections/db/sql/device/smb/CMakeLists.txt (fc27d5a)
>    - src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.h
>    (c74c840)
>    - src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp
>    (2f19e28)
>
> View Diff <http://git.reviewboard.kde.org/r/100725/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110516/787b2d28/attachment.htm