Review Request: Fix multiple issues with the lyrics applet/engine

[Martin Blumenstingl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100892/
-----------------------------------------------------------

Review request for Amarok and Rick W. Chen.


Summary
-------

This fixes the following lyrics related issues:
-Amarok crashed when the lyrics applet was removed and re-added while a track was playing and the user pressed "ESC".
-If no lyrics script was running cached lyrics were not displayed (but an error message that no scripts are running instead).
-HTML lyrics were not displayed (this is a regression).
-If the user edited the lyrics in TagDialog the changes were not "synchronized" to the lyrics applet (this is probably also a regression).

Can we make sure this patch gets into the next release?


Diffs
-----

  src/context/applets/lyrics/LyricsApplet.cpp c3d82db 
  src/context/engines/lyrics/LyricsEngine.h dd6beb9 
  src/context/engines/lyrics/LyricsEngine.cpp d346511 

Diff: http://git.reviewboard.kde.org/r/100892/diff


Testing
-------

-HTML lyrics are working again
-Amarok does not crash anymore when re-adding the lyrics applet and pressing "ESC"
etc.


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110319/c563c706/attachment.htm