Review Request: fix detection of IPod Classic (at least)

[Cristi Posoiu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100889/
-----------------------------------------------------------

(Updated March 20, 2011, 8:35 a.m.)


Review request for Amarok.


Changes
-------

now checks also for vendor string to contain apple.


Summary
-------

Using KDE 4.6.1 (Mandriva Cooker, x86_64) and Amarok 2.4.0.
It seems I have the same problem people are complaining in http://forum.kde.org/viewtopic.php?f=115&t=93018

Amarok sees my ipod only as a simple usb storage disk, even though in it there are those particular directories and files (iPod_Control/, SysExtendedInfo, etc).
When plugging, I get /dev/sdb1 mounted.
Running solid-hardware list details, KDE Solid is returning for it a Vendor name ("Apple") and as product, since it is a partition, the partition label.
As such, code from .../support/IpodConnectionAssistant.cpp can't match it.
In Solid data, /dev/sdb shows though the appropriate product string ("iPod").

So, what this code does, is that it tries to do that product string matching also on parent's device.


Diffs (updated)
-----

  src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp 92339ff 

Diff: http://git.reviewboard.kde.org/r/100889/diff


Testing
-------

started amarok and I get to see my ipod + everything on it.


Thanks,

Cristi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110320/ecf61a2c/attachment-0001.htm