<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100892/">http://git.reviewboard.kde.org/r/100892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Rick W. Chen.</div>
<div>By Martin Blumenstingl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes the following lyrics related issues:
-Amarok crashed when the lyrics applet was removed and re-added while a track was playing and the user pressed "ESC".
-If no lyrics script was running cached lyrics were not displayed (but an error message that no scripts are running instead).
-HTML lyrics were not displayed (this is a regression).
-If the user edited the lyrics in TagDialog the changes were not "synchronized" to the lyrics applet (this is probably also a regression).
Can we make sure this patch gets into the next release?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-HTML lyrics are working again
-Amarok does not crash anymore when re-adding the lyrics applet and pressing "ESC"
etc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/lyrics/LyricsApplet.cpp <span style="color: grey">(c3d82db)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.h <span style="color: grey">(dd6beb9)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: grey">(d346511)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100892/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>