Review Request: Only expose one menubar
Aurélien Gâteau
agateau at kde.org
Thu Mar 17 18:29:15 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100882/
-----------------------------------------------------------
Review request for Amarok.
Summary
-------
ServiceBase creates a KMenuBar. This confuses the Kubuntu widget which allows displaying menubars outside applications ( https://launchpad.net/plasma-widget-menubar ). This simple patch ensures ServiceBase menubar does not try to advertise itself as the native menubar of the application.
Diffs
-----
src/services/ServiceBase.cpp fb7a864
Diff: http://git.reviewboard.kde.org/r/100882/diff
Testing
-------
Started Amarok with and without the Plasma menubar widget, did not notice any unexpected behavior.
Thanks,
Aurélien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110317/74279c11/attachment.htm
More information about the Amarok-devel
mailing list