Review Request: Only expose one menubar

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100882/#review2017
-----------------------------------------------------------

Ship it!


Yup, it works.

Thanks for reminding me of desktop menubar :) I haven't used it since 3.5 times because it was a missing feature for a while.

- Bart


On March 17, 2011, 5:29 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100882/
> -----------------------------------------------------------
> 
> (Updated March 17, 2011, 5:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> ServiceBase creates a KMenuBar. This confuses the Kubuntu widget which allows displaying menubars outside applications ( https://launchpad.net/plasma-widget-menubar ). This simple patch ensures ServiceBase menubar does not try to advertise itself as the native menubar of the application.
> 
> 
> Diffs
> -----
> 
>   src/services/ServiceBase.cpp fb7a864 
> 
> Diff: http://git.reviewboard.kde.org/r/100882/diff
> 
> 
> Testing
> -------
> 
> Started Amarok with and without the Plasma menubar widget, did not notice any unexpected behavior.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110317/38c05441/attachment.htm