[amarok] HACKING: add checklist for commits to HACKING

[Lydia Pintscher]

Git commit 03812d19075e5fca64061863fd1f809cbd9a3652 by Lydia Pintscher.
Committed on 03/03/2011 at 14:40.
Pushed by lydia into branch 'master'.

add checklist for commits to HACKING
it's supposed to help new contributors make sure they don't forget anything important
please add if something important is missing

CCMAIL: amarok-devel at kde.org

A  +16   -0    HACKING/commitchecklist.txt         [License: UNKNOWN]  *

The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


http://commits.kde.org/amarok/03812d19075e5fca64061863fd1f809cbd9a3652

diff --git a/HACKING/commitchecklist.txt b/HACKING/commitchecklist.txt
new file mode 100644
index 0000000..bac94ad
--- /dev/null
+++ b/HACKING/commitchecklist.txt
@@ -0,0 +1,16 @@
+The following checklist is supposed to help you make sure you don't forget anything important in a commit.
+
+For every commit:
+* Does it conform to Amarok's coding style?
+* Is there a feature request, bug report or review request associated with it? (Please close them with the commit message.)
+* Does it introduce new dependencies?
+* Does it add new strings? Is Amarok in string freeze?
+
+Additionally for commits introducing new features:
+* Does it fit Amarok's vision or at least not work against it?
+* Who will maintain the code?
+* Is Amarok in feature freeze?
+* Do existing regression tests still pass?
+* Are new tests needed?
+* Has it been reviewed by a usability person?
+* Does user documentation exist?