Review Request: Do not show the OSD if a fullscreen application is active

[Kevin Funk]

> On June 5, 2011, 4:47 a.m., Bart Cerneels wrote:
> > I think this is a nice feature. I've been starting to QtCreator full screen and yesterday indeed disabled track notifications in order to focus better.
> > Guess my question is: should this also affect the notifications?

Yep, Martin, please also apply this to the KNotificationBackend. It should be straight forward. 

I'm basically the maintainer of the Notification modules, it would be a good idea to use a common base (proxy) for all notification backends to simplify features like this. (Didn't have time to do it, yet)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101508/#review3676
-----------------------------------------------------------


On June 4, 2011, 8:36 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101508/
> -----------------------------------------------------------
> 
> (Updated June 4, 2011, 8:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> It can be quite annoying if fullscreen applications are running and you are controlling amarok via keyboard shortcuts.
> Then the OSD disturbs you.
> 
> To work around this I simply added a little check which does not show the OSD if a fullscreen application is focused/active.
> Of course this is configurable.
> 
> The behavior does not change with this patch, as the setting defaults to "false".
> 
> 
> Diffs
> -----
> 
>   src/amarokconfig.kcfg 6957e93 
>   src/configdialog/dialogs/NotificationsConfig.cpp 52a0584 
>   src/configdialog/dialogs/NotificationsConfig.ui 3b0c47f 
>   src/widgets/Osd.h fa0755f 
>   src/widgets/Osd.cpp c6b1d22 
> 
> Diff: http://git.reviewboard.kde.org/r/101508/diff
> 
> 
> Testing
> -------
> 
> Tested it with the checkbox enabled and disabled.
> Works as expected.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110605/f00c18e6/attachment.htm