Review Request: Do not show the OSD if a fullscreen application is active

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101508/#review3676
-----------------------------------------------------------


I think this is a nice feature. I've been starting to QtCreator full screen and yesterday indeed disabled track notifications in order to focus better.
Guess my question is: should this also affect the notifications?

- Bart


On June 4, 2011, 8:36 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101508/
> -----------------------------------------------------------
> 
> (Updated June 4, 2011, 8:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> It can be quite annoying if fullscreen applications are running and you are controlling amarok via keyboard shortcuts.
> Then the OSD disturbs you.
> 
> To work around this I simply added a little check which does not show the OSD if a fullscreen application is focused/active.
> Of course this is configurable.
> 
> The behavior does not change with this patch, as the setting defaults to "false".
> 
> 
> Diffs
> -----
> 
>   src/amarokconfig.kcfg 6957e93 
>   src/configdialog/dialogs/NotificationsConfig.cpp 52a0584 
>   src/configdialog/dialogs/NotificationsConfig.ui 3b0c47f 
>   src/widgets/Osd.h fa0755f 
>   src/widgets/Osd.cpp c6b1d22 
> 
> Diff: http://git.reviewboard.kde.org/r/101508/diff
> 
> 
> Testing
> -------
> 
> Tested it with the checkbox enabled and disabled.
> Works as expected.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110605/5f253f85/attachment-0001.htm