<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101508/">http://git.reviewboard.kde.org/r/101508/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 5th, 2011, 4:47 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this is a nice feature. I've been starting to QtCreator full screen and yesterday indeed disabled track notifications in order to focus better.
Guess my question is: should this also affect the notifications?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, Martin, please also apply this to the KNotificationBackend. It should be straight forward.
I'm basically the maintainer of the Notification modules, it would be a good idea to use a common base (proxy) for all notification backends to simplify features like this. (Didn't have time to do it, yet)</pre>
<br />
<p>- Kevin</p>
<br />
<p>On June 4th, 2011, 8:36 p.m., Martin Blumenstingl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Martin Blumenstingl.</div>
<p style="color: grey;"><i>Updated June 4, 2011, 8:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It can be quite annoying if fullscreen applications are running and you are controlling amarok via keyboard shortcuts.
Then the OSD disturbs you.
To work around this I simply added a little check which does not show the OSD if a fullscreen application is focused/active.
Of course this is configurable.
The behavior does not change with this patch, as the setting defaults to "false".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it with the checkbox enabled and disabled.
Works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarokconfig.kcfg <span style="color: grey">(6957e93)</span></li>
<li>src/configdialog/dialogs/NotificationsConfig.cpp <span style="color: grey">(52a0584)</span></li>
<li>src/configdialog/dialogs/NotificationsConfig.ui <span style="color: grey">(3b0c47f)</span></li>
<li>src/widgets/Osd.h <span style="color: grey">(fa0755f)</span></li>
<li>src/widgets/Osd.cpp <span style="color: grey">(c6b1d22)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101508/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>