Review Request: Remove includeCollection and excludeCollection

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100425/#review1006
-----------------------------------------------------------

Ship it!


If It unused, and removing of It won't have side-effects, then cut It off. It can be turned back any time, If some problems will appear.

- Sergey


On Jan. 19, 2011, 4:54 p.m., Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100425/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2011, 4:54 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> They seem to be unused and even unimplemented in various query makers.
> The only place where they seem to make sense are the MetaQueryMaker and at this place they were only handed down.
> The only place where it is implemented is SqlQueryMaker and PlaydarQueryMaker
> The only place where it is exported is through the XmlRead/Write Query Maker
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/DynamicModel.cpp dd98b4d 
>   src/context/engines/labels/LabelsEngine.cpp c8aa8d4 
>   src/core-impl/collections/db/sql/SqlQueryMaker.h 027840d 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp 82e0212 
>   src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h e7f6f85 
>   src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp e38b625 
>   src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h d90ec60 
>   src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp aff9627 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h 01bd29f 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp 6669f68 
>   src/core-impl/collections/support/MemoryQueryMaker.h 027498a 
>   src/core-impl/collections/support/MemoryQueryMaker.cpp 182501d 
>   src/core-impl/collections/support/XmlQueryReader.cpp b1d40a5 
>   src/core-impl/collections/support/XmlQueryWriter.h 38d7b96 
>   src/core-impl/collections/support/XmlQueryWriter.cpp 76e8bdf 
>   src/core-impl/collections/upnpcollection/UpnpQueryMaker.h dc27caf 
>   src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 734e486 
>   src/core/collections/MetaQueryMaker.h dd870ad 
>   src/core/collections/MetaQueryMaker.cpp 0ef3cab 
>   src/core/collections/QueryMaker.h 47baa80 
>   src/playlistgenerator/Preset.cpp 2521558 
>   src/services/DynamicServiceQueryMaker.h a931752 
>   src/services/DynamicServiceQueryMaker.cpp aaa704c 
>   src/services/ServiceSqlQueryMaker.h 4eaccbb 
>   src/services/ServiceSqlQueryMaker.cpp 2cb1242 
> 
> Diff: http://git.reviewboard.kde.org/r/100425/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110120/53cd0c4b/attachment.htm