Review Request: avoid crash (segmentation fault) with connected iphone4 while browsing "Local Music"

[Roman Malytskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100402/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Go to Media Sources->Local Music->Apple iPhone->... Amarok crashes.

An infinite loop occurres in "MediaDeviceMeta::prettyUrl()" when name of the track is unknown (empty). 

Function "MediaDeviceMeta::prettyUrl" calls "Meta::Track::prettyName", then "Meta::Track::prettyName" calls (because name().isEmpty()== true) calls "MediaDeviceMeta::prettyUrl" -> segmentation fault.


Diffs
-----

  src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 4d23d7d 

Diff: http://git.reviewboard.kde.org/r/100402/diff


Testing
-------


Thanks,

Roman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110119/453dbb86/attachment.html