<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100425/">http://git.reviewboard.kde.org/r/100425/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If It unused, and removing of It won't have side-effects, then cut It off. It can be turned back any time, If some problems will appear.</pre>
<br />
<p>- Sergey</p>
<br />
<p>On January 19th, 2011, 4:54 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2011, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They seem to be unused and even unimplemented in various query makers.
The only place where they seem to make sense are the MetaQueryMaker and at this place they were only handed down.
The only place where it is implemented is SqlQueryMaker and PlaydarQueryMaker
The only place where it is exported is through the XmlRead/Write Query Maker
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/playlistbrowser/DynamicModel.cpp <span style="color: grey">(dd98b4d)</span></li>
<li>src/context/engines/labels/LabelsEngine.cpp <span style="color: grey">(c8aa8d4)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.h <span style="color: grey">(027840d)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: grey">(82e0212)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h <span style="color: grey">(e7f6f85)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp <span style="color: grey">(e38b625)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h <span style="color: grey">(d90ec60)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp <span style="color: grey">(aff9627)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h <span style="color: grey">(01bd29f)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp <span style="color: grey">(6669f68)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.h <span style="color: grey">(027498a)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: grey">(182501d)</span></li>
<li>src/core-impl/collections/support/XmlQueryReader.cpp <span style="color: grey">(b1d40a5)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.h <span style="color: grey">(38d7b96)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.cpp <span style="color: grey">(76e8bdf)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.h <span style="color: grey">(dc27caf)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(734e486)</span></li>
<li>src/core/collections/MetaQueryMaker.h <span style="color: grey">(dd870ad)</span></li>
<li>src/core/collections/MetaQueryMaker.cpp <span style="color: grey">(0ef3cab)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: grey">(47baa80)</span></li>
<li>src/playlistgenerator/Preset.cpp <span style="color: grey">(2521558)</span></li>
<li>src/services/DynamicServiceQueryMaker.h <span style="color: grey">(a931752)</span></li>
<li>src/services/DynamicServiceQueryMaker.cpp <span style="color: grey">(aaa704c)</span></li>
<li>src/services/ServiceSqlQueryMaker.h <span style="color: grey">(4eaccbb)</span></li>
<li>src/services/ServiceSqlQueryMaker.cpp <span style="color: grey">(2cb1242)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100425/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>