Review Request: Implements a preview button in the collection organizer dialog along with an "automatic preview" checkbox

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100270/#review1007
-----------------------------------------------------------


Good Idea, I would found such feature very useful when I was reorganizing my collection, not so huge, but big enough to slow dialog and type speed down to 1 symbol per 10 seconds. :) 


src/dialogs/OrganizeCollectionDialog.h
<http://git.reviewboard.kde.org/r/100270/#comment809>

    Why don't just compare sender() with ui->previewButton, since It is the only widget that can force preview update?



src/dialogs/OrganizeCollectionDialog.cpp
<http://git.reviewboard.kde.org/r/100270/#comment808>

    Default value should be in declaration.


- Sergey


On Dec. 30, 2010, 9:34 p.m., Maximilian Güntner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100270/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2010, 9:34 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch adds manual preview functionality to the collection organizer dialog. This is very handy when altering the filename scheme and options of large collections ( > 1k files) since the dialog doesn't update the preview widget with every change in the filename configurator. The current functionality can be achieved by clicking on "Automatic Preview". Hope you like it.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/OrganizeCollectionDialog.h f2ef834 
>   src/dialogs/OrganizeCollectionDialog.cpp b7d7850 
>   src/dialogs/OrganizeCollectionDialogBase.ui 2f28102 
> 
> Diff: http://git.reviewboard.kde.org/r/100270/diff
> 
> 
> Testing
> -------
> 
> -tested auto update by using/clicking each element that connects to the signalmapper
> -tested the manual preview button
> -moved a collection
> 
> 
> Screenshots
> -----------
> 
> Preview Button and auto preview checkbox
>   http://git.reviewboard.kde.org/r/100270/s/31/
> 
> 
> Thanks,
> 
> Maximilian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110120/46cbc41b/attachment.htm