Review Request: Update Amarok to work with Cagibi >= 0.2.0 D-BUS API

[Nikhil Shantanu Marathe]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102384/
-----------------------------------------------------------

(Updated Aug. 26, 2011, 7:53 a.m.)


Review request for Amarok and Bart Cerneels.


Changes
-------

Fix style issues.


Summary
-------

Cagibi 0.2.0 changed the D-BUS API including method locations and the return format of deviceDetails.
At the same time, since Amarok still has KDE 4.4 as the lowest requirement, Cagibi 0.1.0 compatibility is required.

This patch adds support for both versions


Diffs (updated)
-----

  src/core-impl/collections/upnpcollection/UpnpCollectionFactory.h f36030e 
  src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 9fdaa45 
  src/core-impl/collections/upnpcollection/dbuscodec.h 158896e 
  src/core-impl/collections/upnpcollection/dbuscodec.cpp b6842cb 
  src/core-impl/collections/upnpcollection/deviceinfo.h 00b5b7f 

Diff: http://git.reviewboard.kde.org/r/102384/diff


Testing
-------

Tested with one device, on both Cagibi 0.1.1 and 0.2.0


Thanks,

Nikhil Shantanu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110826/79383982/attachment.html>