Review Request: Update Amarok to work with Cagibi >= 0.2.0 D-BUS API

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102384/#review5908
-----------------------------------------------------------



src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp
<http://git.reviewboard.kde.org/r/102384/#comment5198>

    coding style says it should looks like this:
    if( !cagibi0_1_0init( QDBusConnection::sessionBus() )
    
    Sorry to bitch about that but it really helps to review your patch if the code is readable for someone really entrenched in the amarok coding style.


Needs a run though astyle (see /HACKING) but I guess it will work.
It's a bit to time intensive for me to test fully, so I'm trusting your skill.

Also, we should consider raising the minimal KDE version for next release.

- Bart


On Aug. 20, 2011, 10:58 a.m., Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102384/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2011, 10:58 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Summary
> -------
> 
> Cagibi 0.2.0 changed the D-BUS API including method locations and the return format of deviceDetails.
> At the same time, since Amarok still has KDE 4.4 as the lowest requirement, Cagibi 0.1.0 compatibility is required.
> 
> This patch adds support for both versions
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/upnpcollection/UpnpCollectionFactory.h f36030e 
>   src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 9fdaa45 
>   src/core-impl/collections/upnpcollection/dbuscodec.h 158896e 
>   src/core-impl/collections/upnpcollection/dbuscodec.cpp b6842cb 
>   src/core-impl/collections/upnpcollection/deviceinfo.h 00b5b7f 
> 
> Diff: http://git.reviewboard.kde.org/r/102384/diff
> 
> 
> Testing
> -------
> 
> Tested with one device, on both Cagibi 0.1.1 and 0.2.0
> 
> 
> Thanks,
> 
> Nikhil Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110822/16213793/attachment.html>