Review Request: Bug 280382: Unable to add applets to Context View (Wrench is absent when zero applets present)

Nikhil Shantanu Marathe nsm.nikhil at gmail.com
Sun Aug 21 09:21:30 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102395/
-----------------------------------------------------------

Review request for Amarok and Leo Franchi.


Summary
-------

The fix is that the wrench is created in the constructor. Earlier it was only being created when an applet was added.

I cannot however get the wrench to stay right aligned when there are zero applets, due to some size hint issues I don't have sufficient knowledge of.


This addresses bug 280382.
    https://bugs.kde.org/show_bug.cgi?id=280382


Diffs
-----

  src/context/toolbar/AppletToolbar.cpp 2bedf38 

Diff: http://git.reviewboard.kde.org/r/102395/diff


Testing
-------

works fine on Amarok git master running on kde master.


Thanks,

Nikhil Shantanu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110821/19ddf419/attachment.html>


More information about the Amarok-devel mailing list