Review Request: Use MetaQueryWidget in the advanced playlist generator.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100070/
-----------------------------------------------------------

(Updated 2010-10-28 17:56:59.867557)


Review request for Amarok.


Changes
-------

The comparer class is back. The .cpp file was just renamed to TagMatchComparer.cpp
It still looks a little bit lonely with just six static functions in one .cpp file on it's own.

Also I noticed that the fuzzy comparisons are really very different, which they probably don't need to be.
Common for fuzzy logic is a normal ramp or triangle function for fuzzy values. I am pretty sure that the exponential is not visible for the user.

Anyway, I tried to write some comments for the functions but it's hard to describe what a fuzzyProb or a rangeNum is. This is usually an indication for me that something needs to be changed because how would you know if the result of the function is correct if you can't describe it.

Still, I hope you are satisfied with the patch now.


Summary
-------

Instead of implementing the whole behavior of selecting field and values I am just using the MetaQueryWidget.

Also I am moving all field related texts to src/core/meta/support/MetaConstants.cpp
This would also be a good place for the playlist to get it's texts from.


Diffs (updated)
-----

  src/CMakeLists.txt 5f2ac9d 
  src/core-impl/collections/support/XmlQueryReader.h 0088608 
  src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 
  src/core-impl/collections/support/XmlQueryWriter.h 11c818e 
  src/core-impl/collections/support/XmlQueryWriter.cpp 657e0c8 
  src/core/CMakeLists.txt 5863ca1 
  src/core/meta/support/MetaConstants.h 10f07d0 
  src/core/meta/support/MetaConstants.cpp PRE-CREATION 
  src/core/meta/support/MetaUtility.h b161bdc 
  src/core/meta/support/MetaUtility.cpp 534a61a 
  src/dynamic/Bias.h 082327c 
  src/dynamic/Bias.cpp 6934a70 
  src/playlistgenerator/PresetModel.cpp 9b74636 
  src/playlistgenerator/constraints/PlaylistDuration.h 992215c 
  src/playlistgenerator/constraints/PlaylistDuration.cpp 5d83dfe 
  src/playlistgenerator/constraints/TagMatch.h 094a68b 
  src/playlistgenerator/constraints/TagMatch.cpp a719825 
  src/playlistgenerator/constraints/TagMatchComparer.cpp PRE-CREATION 
  src/playlistgenerator/constraints/TagMatchEditWidget.ui b9d97c6 
  src/playlistgenerator/constraints/TagMatchSupport.cpp d368931 
  src/widgets/MetaQueryWidget.h ba64e4c 
  src/widgets/MetaQueryWidget.cpp 5316ec6 

Diff: http://git.reviewboard.kde.org/r/100070/diff


Testing
-------

Generated several advanced playlists testing a couple of the fields and all the conditions.


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101028/d4a22787/attachment.htm