Review Request: Use MetaQueryWidget in the advanced playlist generator.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100070/
-----------------------------------------------------------

(Updated 2010-10-22 00:20:31.922652)


Review request for Amarok.


Changes
-------

Surprisingly the label stuff works now.
Cool.
If only the labels would be saved to the files now.

The updated patch is attached.


Summary
-------

Instead of implementing the whole behavior of selecting field and values I am just using the MetaQueryWidget.

Also I am moving all field related texts to src/core/meta/support/MetaConstants.cpp
This would also be a good place for the playlist to get it's texts from.


Diffs (updated)
-----

  src/CMakeLists.txt 45a9493 
  src/core-impl/collections/support/XmlQueryReader.h 0088608 
  src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 
  src/core-impl/collections/support/XmlQueryWriter.h 11c818e 
  src/core-impl/collections/support/XmlQueryWriter.cpp 657e0c8 
  src/core/CMakeLists.txt 5863ca1 
  src/core/meta/support/MetaConstants.h 40cad34 
  src/core/meta/support/MetaConstants.cpp PRE-CREATION 
  src/core/meta/support/MetaUtility.h b161bdc 
  src/core/meta/support/MetaUtility.cpp 0bb29db 
  src/dynamic/Bias.h 082327c 
  src/dynamic/Bias.cpp 6934a70 
  src/playlistgenerator/PresetModel.cpp 9b74636 
  src/playlistgenerator/constraints/PlaylistDuration.h 992215c 
  src/playlistgenerator/constraints/PlaylistDuration.cpp 5d83dfe 
  src/playlistgenerator/constraints/TagMatch.h 094a68b 
  src/playlistgenerator/constraints/TagMatch.cpp a719825 
  src/playlistgenerator/constraints/TagMatchEditWidget.ui b9d97c6 
  src/playlistgenerator/constraints/TagMatchSupport.cpp d368931 
  src/widgets/MetaQueryWidget.h ba64e4c 
  src/widgets/MetaQueryWidget.cpp 5316ec6 

Diff: http://git.reviewboard.kde.org/r/100070/diff


Testing
-------

Generated several advanced playlists testing a couple of the fields and all the conditions.


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101022/845ed27e/attachment-0001.htm