Review Request: Add reading/writing of UIDs (MusicBrainz & AFT) for MPC and MP4 files. Also support of this formats for AFTTagger.

[Rick W. Chen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100080/#review157
-----------------------------------------------------------



utilities/afttagger/AFTTagger.cpp
<http://git.reviewboard.kde.org/r/100080/#comment141>

    the frame doesn't actually get removed.



utilities/afttagger/AFTTagger.cpp
<http://git.reviewboard.kde.org/r/100080/#comment138>

    need a file->save() here for the new fields to be saved.



utilities/afttagger/AFTTagger.cpp
<http://git.reviewboard.kde.org/r/100080/#comment140>

    indent issue



utilities/afttagger/AFTTagger.cpp
<http://git.reviewboard.kde.org/r/100080/#comment149>

    the frame doesn't actually get removed.



utilities/afttagger/AFTTagger.cpp
<http://git.reviewboard.kde.org/r/100080/#comment139>

    need a file->save() here for the new fields to be saved.



utilities/collectionscanner/AFTUtility.cpp
<http://git.reviewboard.kde.org/r/100080/#comment143>

    pre-increment and cache end iterator



utilities/collectionscanner/AFTUtility.cpp
<http://git.reviewboard.kde.org/r/100080/#comment144>

    At the moment for (mp3, flac, ogg) the AFT is checked first then mbid. We should be consistent for the new formats as well.



utilities/collectionscanner/AFTUtility.cpp
<http://git.reviewboard.kde.org/r/100080/#comment148>

    indent issue



utilities/collectionscanner/AFTUtility.cpp
<http://git.reviewboard.kde.org/r/100080/#comment146>

    ourID needs .toUpper() for the keys to match



utilities/collectionscanner/AFTUtility.cpp
<http://git.reviewboard.kde.org/r/100080/#comment147>

    pre-increment and cache end iterator.


- Rick W.


On 2010-10-18 18:09:46, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100080/
> -----------------------------------------------------------
> 
> (Updated 2010-10-18 18:09:46)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add code for reading/writing MusicBrainz and AFT (used as default if no uid_owner specified) UIDs from/to MPC and MP4 files.
> Add support of MPC and MP4 formats for AFTTagger utility.
> Also add "uid_owner" and "uid" constants to Meta::Fields::ID namespace.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 97969be 
>   src/core-impl/meta/file/File.cpp b807cba 
>   src/core-impl/meta/file/TagLibUtils.cpp ad1a07e 
>   src/core/meta/support/MetaConstants.h 40cad34 
>   src/dialogs/TagDialog.cpp 4a0e94f 
>   src/musicbrainz/MusicBrainzFinder.cpp f65e25d 
>   src/musicbrainz/MusicBrainzMetaClasses.h b9f7d0c 
>   utilities/afttagger/AFTTagger.h 8921875 
>   utilities/afttagger/AFTTagger.cpp 2aa9aef 
>   utilities/collectionscanner/AFTUtility.cpp fde3bfa 
> 
> Diff: http://git.reviewboard.kde.org/r/100080/diff
> 
> 
> Testing
> -------
> 
> Tried on couple of MPC files, UIDs write correct. AFTTagger not tested at all, didn't find a way to make it well.
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101020/668ec6c3/attachment-0001.htm