Review Request: Add reading/writing of UIDs (MusicBrainz & AFT) for MPC and MP4 files. Also support of this formats for AFTTagger.

[Sergey Ivanov]

> On 2010-10-20 20:03:22, Rick W. Chen wrote:
> > utilities/afttagger/AFTTagger.cpp, line 560
> > <http://git.reviewboard.kde.org/r/100080/diff/1/?file=1104#file1104line560>
> >
> >     the frame doesn't actually get removed.

There is cleaning loop below.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100080/#review157
-----------------------------------------------------------


On 2010-10-20 21:11:19, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100080/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 21:11:19)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add code for reading/writing MusicBrainz and AFT (used as default if no uid_owner specified) UIDs from/to MPC and MP4 files.
> Add support of MPC and MP4 formats for AFTTagger utility.
> Also add "uid_owner" and "uid" constants to Meta::Fields::ID namespace.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 97969be 
>   src/core-impl/meta/file/File.cpp b807cba 
>   src/core-impl/meta/file/TagLibUtils.cpp ad1a07e 
>   src/core/meta/support/MetaConstants.h 40cad34 
>   src/dialogs/TagDialog.cpp 4a0e94f 
>   src/musicbrainz/MusicBrainzFinder.cpp f65e25d 
>   src/musicbrainz/MusicBrainzMetaClasses.h b9f7d0c 
>   utilities/afttagger/AFTTagger.h 8921875 
>   utilities/afttagger/AFTTagger.cpp 2aa9aef 
>   utilities/collectionscanner/AFTUtility.cpp fde3bfa 
> 
> Diff: http://git.reviewboard.kde.org/r/100080/diff
> 
> 
> Testing
> -------
> 
> Tried on couple of MPC files, UIDs write correct. AFTTagger not tested at all, didn't find a way to make it well.
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101020/75b8a3e7/attachment.htm