Review Request: MusicBrainz Tagger "restyling"

[Lukas]

Hi,

Its nice to see such improvement :)

Just a few things to add - It looks like entire result gets compared to
entire data from track. It's hardly the best way to it, since the longer
correct part is, the more similar results looks like. From the screen shots
its obviously not - while title and artist remains the same, album is
entirely different - so its not that close match.

That's why, I think it is better to match field to field and use average to
sort results down.

This means title gets compared to title, album to album etc. Doing so would
draw user attention to the field that has difference.
To indicate match level/ration discrete rather than continuous colors might
be used.
* None (or default background color) - If the is no difference
* Green - Difference is quite minor (like misspells, or fixing capitals)
* Yellow - There is some similarity e.g. one is a substring of another ("top
dance" and "Top Dance vol 2.0")
* Red - Almost nothing is in common (line in screenshots album filed)

To prevent color noise, only {border-bottom: 3px COLOR solid; font-weight:
bold } (no bold for "none" color) an be used instead of entire background.
Such way even color blind will know where to drag attention (bold)

Thanks,

Lukas



On 2 November 2010 17:32, Sergey Ivanov <123kash at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100127/
>   Review request for Amarok.
> By Sergey Ivanov.
>
> *Updated 2010-11-02 15:32:21.079819*
> Changes
>
> Change gradients for results ( (orange) FFAA00->55FF00 (green) for MusicBrainz; (cyan)00AAFF->00FF55(green) for MusicDNS and green (00FF00) if track found by both engines).
> Tooltips with match ratio.
>
>   Description
>
> Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch->SearchResults. Search results sorted by similarity ratio ( more similar is on top ), and has different colors corresponding to that. MusicDNS search results marked with a cyan color and stay on bottom. There is no Start search button any more, both searches run simultaneously.
>
> Will be Implemented soon:
> 1) If one TrackID founded by both searches, this result automatically moves on top.
> 2) MB icon linked to track page on musicbrainz.org. //need to find a place for It
> 3..n Needs your advices. :)
>
>   Diffs (updated)
>
>    - src/CMakeLists.txt (2abeca2)
>    - src/dialogs/MusicBrainzTagger.h (e33c9f6)
>    - src/dialogs/MusicBrainzTagger.cpp (cdc3ec5)
>    - src/dialogs/MusicBrainzTagger.ui (3f14236)
>    - src/dialogs/TagDialog.cpp (e98acf5)
>    - src/musicbrainz/MusicBrainzFinder.h (49c8f6b)
>    - src/musicbrainz/MusicBrainzFinder.cpp (41ddbaa)
>    - src/musicbrainz/MusicBrainzMeta.h (57ed363)
>    - src/musicbrainz/MusicBrainzTagsModel.h (a93929a)
>    - src/musicbrainz/MusicBrainzTagsModel.cpp (1bf7389)
>    - src/musicbrainz/MusicBrainzTrackListModel.h (6eaa648)
>    - src/musicbrainz/MusicBrainzTrackListModel.cpp (fa1fc10)
>    - src/musicbrainz/MusicDNSFinder.h (2cd00d1)
>    - src/musicbrainz/MusicDNSFinder.cpp (9c31f38)
>
> View Diff <http://git.reviewboard.kde.org/r/100127/diff/>
> Screenshots (updated)
>  <http://git.reviewboard.kde.org/r/100127/s/12/>
> <http://git.reviewboard.kde.org/r/100127/s/13/>
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101102/a363caa5/attachment.htm