Hi,<br><br>Its nice to see such improvement :)<br><br>Just a few things to add - It looks like entire result gets compared to entire data from track. It's hardly the best way to it, since the longer correct part is, the more similar results looks like. From the screen shots its obviously not - while title and artist remains the same, album is entirely different - so its not that close match.<br>
<br>That's why, I think it is better to match field to field and use average to sort results down.<br><br>This means title gets compared to title, album to album etc. Doing so would draw user attention to the field that has difference.<br>
To indicate match level/ration discrete rather than continuous colors might be used.<br>* None (or default background color) - If the is no difference<br>* Green - Difference is quite minor (like misspells, or fixing capitals)<br>
* Yellow - There is some similarity e.g. one is a substring of another ("top dance" and "Top Dance vol 2.0")<br>* Red - Almost nothing is in common (line in screenshots album filed)<br><br>To prevent color noise, only {border-bottom: 3px COLOR solid; font-weight: bold } (no bold for "none" color) an be used instead of entire background. <br>
Such way even color blind will know where to drag attention (bold)<br><br>Thanks,<br><br>Lukas<br><br><br><br><div class="gmail_quote">On 2 November 2010 17:32, Sergey Ivanov <span dir="ltr"><<a href="mailto:123kash@gmail.com">123kash@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;"><div class="im">
<table style="border: 1px solid rgb(201, 195, 153);" width="100%" bgcolor="#f9f3c9" cellpadding="8">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100127/" target="_blank">http://git.reviewboard.kde.org/r/100127/</a>
</td>
</tr>
</tbody></table>
<br>
</div><table style="background-repeat: repeat-x; border: 1px solid black;" width="100%" bgcolor="#fefadf" cellpadding="8" cellspacing="0">
<tbody><tr>
<td><div class="im">
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
</div><p style="color: grey;"><i>Updated 2010-11-02 15:32:21.079819</i></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table style="border: 1px solid rgb(184, 181, 160);" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">Change gradients for results ( (orange) FFAA00->55FF00 (green) for MusicBrainz; (cyan)00AAFF->00FF55(green) for MusicDNS and green (00FF00) if track found by both engines).
Tooltips with match ratio. </pre>
</td>
</tr>
</tbody></table><div class="im">
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch->SearchResults. Search results sorted by similarity ratio ( more similar is on top ), and has different colors corresponding to that. MusicDNS search results marked with a cyan color and stay on bottom. There is no Start search button any more, both searches run simultaneously.
Will be Implemented soon:
1) If one TrackID founded by both searches, this result automatically moves on top.
2) MB icon linked to track page on <a href="http://musicbrainz.org" target="_blank">musicbrainz.org</a>. //need to find a place for It
3..n Needs your advices. :)</pre>
</td>
</tr>
</tbody></table>
</div><h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Diffs (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0pt;"><div class="im">
<li>src/CMakeLists.txt <span style="color: grey;">(2abeca2)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: grey;">(e33c9f6)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: grey;">(cdc3ec5)</span></li>
<li>src/dialogs/MusicBrainzTagger.ui <span style="color: grey;">(3f14236)</span></li>
</div><li>src/dialogs/TagDialog.cpp <span style="color: grey;">(e98acf5)</span></li><div class="im">
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: grey;">(49c8f6b)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey;">(41ddbaa)</span></li>
<li>src/musicbrainz/MusicBrainzMeta.h <span style="color: grey;">(57ed363)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: grey;">(a93929a)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: grey;">(1bf7389)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.h <span style="color: grey;">(6eaa648)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.cpp <span style="color: grey;">(fa1fc10)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: grey;">(2cd00d1)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: grey;">(9c31f38)</span></li>
</div></ul>
<p><a href="http://git.reviewboard.kde.org/r/100127/diff/" style="margin-left: 3em;" target="_blank">View Diff</a></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100127/s/12/" target="_blank"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/02/MBT_400x100.png" style="border: 1px solid black;" alt=""></a>
<a href="http://git.reviewboard.kde.org/r/100127/s/13/" target="_blank"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/02/MBT1_400x100.png" style="border: 1px solid black;" alt=""></a>
</div>
</td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
<br></blockquote></div>