Review Request: MusicBrainz Tagger "restyling"

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100127/
-----------------------------------------------------------

(Updated 2010-11-02 15:32:21.079819)


Review request for Amarok.


Changes
-------

Change gradients for results ( (orange) FFAA00->55FF00 (green) for MusicBrainz; (cyan)00AAFF->00FF55(green) for MusicDNS and green (00FF00) if track found by both engines).
Tooltips with match ratio. 


Summary
-------

Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch->SearchResults. Search results sorted by similarity ratio ( more similar is on top ), and has different colors corresponding to that. MusicDNS search results marked with a cyan color and stay on bottom. There is no Start search button any more, both searches run simultaneously.

Will be Implemented soon:
1) If one TrackID founded by both searches, this result automatically moves on top.
2) MB icon linked to track page on musicbrainz.org. //need to find a place for It
3..n Needs your advices. :)


Diffs (updated)
-----

  src/CMakeLists.txt 2abeca2 
  src/dialogs/MusicBrainzTagger.h e33c9f6 
  src/dialogs/MusicBrainzTagger.cpp cdc3ec5 
  src/dialogs/MusicBrainzTagger.ui 3f14236 
  src/dialogs/TagDialog.cpp e98acf5 
  src/musicbrainz/MusicBrainzFinder.h 49c8f6b 
  src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa 
  src/musicbrainz/MusicBrainzMeta.h 57ed363 
  src/musicbrainz/MusicBrainzTagsModel.h a93929a 
  src/musicbrainz/MusicBrainzTagsModel.cpp 1bf7389 
  src/musicbrainz/MusicBrainzTrackListModel.h 6eaa648 
  src/musicbrainz/MusicBrainzTrackListModel.cpp fa1fc10 
  src/musicbrainz/MusicDNSFinder.h 2cd00d1 
  src/musicbrainz/MusicDNSFinder.cpp 9c31f38 

Diff: http://git.reviewboard.kde.org/r/100127/diff


Testing
-------


Screenshots (updated)
-----------


  http://git.reviewboard.kde.org/r/100127/s/12/

  http://git.reviewboard.kde.org/r/100127/s/13/


Thanks,

Sergey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101102/7dcf87eb/attachment.htm